Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix captcha text color #964

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Fix captcha text color #964

merged 4 commits into from
Jan 12, 2024

Conversation

forgetso
Copy link
Member

@forgetso forgetso commented Jan 11, 2024 •
edited
Loading

Text isn't showing up.

@pr-explainer-bot PR Explainer Bot
Copy link

Pull Request Report

Hello! Here's a report for the pull request:

Changes

  1. Added a production key for the database config in prosopo.config.ts (lines 64-70).

Suggestions

  1. In Procaptcha.tsx (line 236), consider changing the color of the text to theme.palette.background.contrastText for better visibility.

Bugs

No bugs found.

Improvements

No improvements found.

Rating

I would rate the code as follows:

  • Readability: 8/10
  • Performance: 9/10
  • Security: 7/10

Great job overall! Keep up the good work!

@forgetso forgetso enabled auto-merge (squash) January 12, 2024 09:14
@forgetso forgetso merged commit 9e00f30 into main Jan 12, 2024
7 checks passed
@forgetso forgetso deleted the fix-captcha-text-color branch January 12, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goastler goastler goastler approved these changes

@HughParry HughParry Awaiting requested review from HughParry HughParry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forgetso @goastler