Skip to content

Commit

Permalink
Extend list of ignored array methods to include fetch_values introd…
Browse files Browse the repository at this point in the history
…uced in Ruby 3.4.
  • Loading branch information
JasonLunn committed Jan 10, 2025
1 parent 8461cda commit 5cc3bc9
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions ruby/tests/repeated_field_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,17 @@ def test_acts_like_enumerator
def test_acts_like_an_array
m = TestMessage.new
arr_methods = ([].methods - TestMessage.new.repeated_string.methods)
# jRuby additions to the Array class that we can ignore
# JRuby additions to the Array class that we ignore
arr_methods -= [ :indices, :iter_for_each, :iter_for_each_index,
:iter_for_each_with_index, :dimensions, :copy_data, :copy_data_simple,
:nitems, :iter_for_reverse_each, :indexes, :append, :prepend]
arr_methods -= [:filter!]
# ruby 2.7 methods we can ignore
# ruby 2.7 methods we ignore
arr_methods -= [:deconstruct, :resolve_feature_path]
# ruby 3.1 methods we can ignore
# ruby 3.1 methods we ignore
arr_methods -= [:intersect?]
# ruby 3.4 methods we ignore
arr_methods -= [:fetch_values]
arr_methods.each do |method_name|
assert_respond_to m.repeated_string, method_name
end
Expand Down

0 comments on commit 5cc3bc9

Please sign in to comment.