Skip to content

Commit

Permalink
tinkering with abaplint again (#75)
Browse files Browse the repository at this point in the history
* tinkering with abaplint again

* more abaplint tinkering

* extending the workflow

* revise the workflow

* more wf refinement

* restaging

* let workflow complete regadless of lint output

* hey more abaplint fixes
  • Loading branch information
fleischr authored Aug 6, 2024
1 parent 9a3494f commit 5baeb95
Show file tree
Hide file tree
Showing 20 changed files with 914 additions and 1,040 deletions.
29 changes: 29 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: CI Build

on:
push:
pull_request:

jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Startup confirmation
run: echo Starting provide-abap build

- name: Checkout repository
uses: actions/checkout@v3

- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '20'

- name: Install abaplint
run: npm install -g @abaplint/cli

- name: Run abaplint and save output
run: abaplint -f json || true


12 changes: 6 additions & 6 deletions abaplint.json
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
"ignoreLocal": true,
"ignoreInterfaces": false,
"statics": "^G._.+$",
"instance": "^M._.+$, ^MI._.+$, ^MV._.+$, ^MS._.+$, ^MO._.+$",
"instance": "^(M|MI|MV|MS|MO)._.+$",
"constants": ""
},
"classic_exceptions_overlap": {
Expand Down Expand Up @@ -518,9 +518,9 @@
"patternKind": "required",
"ignoreNames": [],
"ignorePatterns": [],
"expectedData": "^L._.+$, ^LV._.+$, ^LS._.+$, ^LO._.+$, ^<FS._.+>$",
"expectedData": "^(L|LV|LS|LO)._.+$",
"expectedConstant": "^LC_.+$",
"expectedFS": "^<L._.+>$, ^<FS._.+>$"
"expectedFS": "^<(L|FS)._.+>$"
},
"main_file_contents": {
"exclude": [],
Expand Down Expand Up @@ -565,10 +565,10 @@
"ignoreNames": [],
"ignorePatterns": [],
"ignoreExceptions": true,
"importing": "^I._.+$, ^IV._.+$ ",
"importing": "^(I|IV)._.+$",
"returning": "^R._.+$",
"changing": "^C._.+$",
"exporting": "^E._.+$, ^EV._.+$, ^ES._.+$ "
"exporting": "^(E|EV)._.+$"
},
"mix_returning": {
"exclude": [],
Expand Down Expand Up @@ -866,7 +866,7 @@
"types_naming": {
"exclude": [],
"severity": "Error",
"pattern": "^TY_.+$, ^TT_.+$, ^TTY_.+$, ^R_.+$"
"pattern": "^(TY|TT|TTY|R)_.+$"
},
"uncaught_exception": {
"exclude": [],
Expand Down
Loading

0 comments on commit 5baeb95

Please sign in to comment.