Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subnets subscriptions. #14682

Closed
wants to merge 2 commits into from
Closed

Refactor subnets subscriptions. #14682

wants to merge 2 commits into from

Conversation

nalepae
Copy link
Contributor

@nalepae nalepae commented Nov 29, 2024 •
edited
Loading

What type of PR is this?
Other

What does this PR do? Why is it needed?
Before this PR, we had 2 functions:

  • subscribeStaticWithSubnets, and
  • subscribeStaticWithSyncSubnets.

These two functions were very similar.
This PR merges these two functions into one.

Before this PR, we had 2 functions:

  • subscribeDynamicWithSubnets, and
  • subscribeDynamicWithSyncSubnets.

This PR creates a new subscribeDynamicWithSubnetsGeneric function.

Even if the count of deleted lines of codes is not really impressive in this refactor, it will avoid, when
integrating data columns subnets with peerDAS, to write an other subscribeStaticWithDataColumnsSubnets and subscribeDynamicWithDataColumnsSubnets.

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@nalepae
Refactor static subnet subscriptions.
ecc8aa5 
Before this commit, we had 2 functions:
- `subscribeStaticWithSubnets`, and
- `subscribeStaticWithSyncSubnets`.

These two functions were very similar.
This commit merge these two functions into one.
@nalepae nalepae changed the title Refactor static subnet subscriptions. Refactor stat subnet subscriptions. Nov 30, 2024
@nalepae nalepae changed the title Refactor stat subnet subscriptions. Refactor subnets subscriptions. Nov 30, 2024
@nalepae nalepae marked this pull request as ready for review November 30, 2024 16:18
@nalepae nalepae requested a review from a team as a code owner November 30, 2024 16:18
@nalepae nalepae added Networking P2P related items Cleanup Code health! labels Nov 30, 2024
terencechain
terencechain approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nalepae nalepae closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Cleanup Code health! Networking P2P related items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalepae @terencechain