Properly configure (or not) bugsnag

przemub · Nov 23, 2024 · ce9c8a5 · ce9c8a5
1 parent 800ddfd
commit ce9c8a5
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 17 deletions.
diff --git a/anime_quiz/settings.py b/anime_quiz/settings.py
@@ -55,6 +55,11 @@
             "class": "logging.StreamHandler",
             "formatter": "default",
         },
+        "bugsnag": {
+            "level": "WARNING",
+            "class": "bugsnag.handlers.BugsnagHandler",
+            "formatter": "default",
+        },
     },
     "formatters": {
         "default": {
@@ -181,5 +186,16 @@
 
 INTERNAL_IPS = os.getenv("INTERNAL_IPS", "192.168.1.1").split(",")
 
+BUGSNAG = None
+if "QUIZ_BUGSNAG" in os.environ:
+    BUGSNAG = {
+        "api_key": os.environ["QUIZ_BUGSNAG"],
+        "project_root": "/usr/src/app",
+        "ignore_classes": ["django.http.Http404"],
+        "release_stage": "development"
+    }
+    LOGGING["loggers"]["root"]["handlers"].append("bugsnag")
+    MIDDLEWARE.append("bugsnag.django.middleware.BugsnagMiddleware")
+
 # Redis database used as a queue for tasks.
 QUEUE_DB = "redis://redis:6379/1"
diff --git a/anime_quiz/settings_prod.py b/anime_quiz/settings_prod.py
@@ -23,19 +23,5 @@
 else:
     raise Exception("QUIZ_SECRET_KEY environment variable is not set!")
 
-if os.environ.get("QUIZ_BUGSNAG", None):
-    BUGSNAG = {
-        "api_key": os.environ["QUIZ_BUGSNAG"],
-        "project_root": "/usr/src/app",
-        "ignore_classes": ["django.http.Http404"],
-        "release_stage": "production"
-    }
-
-    LOGGING["handlers"]["bugsnag"] = {
-        "level": "INFO",
-        "class": "bugsnag.handlers.BugsnagHandler",
-        "formatter": "default",
-    }
-    LOGGING["loggers"]["root"]["handlers"].append("bugsnag")
-
-    MIDDLEWARE += ["bugsnag.django.middleware.BugsnagMiddleware"]
+if BUGSNAG is not None:
+    BUGSNAG["release_stage"] = "production"
diff --git a/quiz/tasks.py b/quiz/tasks.py
@@ -94,7 +94,7 @@ def listen_for_tasks(self) -> NoReturn:
                     self.name,
                     kwargs
                 )
-                if settings.get("BUGSNAG"):
+                if settings.BUGSNAG is not None:
                     bugsnag.notify(e)
             else:
                 logger.info(
@@ -211,6 +211,8 @@ def listen_for_tasks():
 
     os.environ.setdefault("DJANGO_SETTINGS_MODULE", "anime_quiz.settings")
     django.setup()
+    if settings.BUGSNAG is not None:
+        bugsnag.configure(**settings.BUGSNAG)
 
     try:
         listen_for_tasks()