Fix tests for windows, which appears to have a lower resolution time #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutat3s
reviewed
Nov 27, 2024
Sorry, I was going to, but I'm really swamped with work. I would have to figure out how to run lint test locally not to push something that would fail again XD I'll try to get to it on the weekend maybe. |
|
No worries and no rush. This is the command we run in the CI: |
b12f
approved these changes
Dec 4, 2024
|
Thanks @sfider! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have around 19 fails when run on windows. Mostly
OSError: [Errno 22] Invalid argumenton4000timestamps (too low resolution time).test_pushalso had issues with recorded times comparing as equal (again, low resolution time). But I also noticed it usedarrow.now()while tested code usesarrow.utcnow(), so I fixed this as well.