added fix for Instant::now() subtraction overflow #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under the case that an individual runs a piece of software depending on this crate, the runtime will panic due to the Instant being smaller than the durection since the UNIX epoch
|
@RealAstolfo thanks a lot, very interesting edge case. I definitely should be careful with OS time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under the case that an individual runs a piece of software depending on this crate, the runtime will panic due to the Instant being smaller than the duration since the UNIX epoch.
You can reproduce this bug by simply restarting your PC (whether its linux or windows, i observed it occurring on both) and then trying to run an application depending on this crate.