Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracing debug logs #7

Merged
merged 3 commits into from
Feb 9, 2024
Merged

feat: add tracing debug logs #7

merged 3 commits into from
Feb 9, 2024

Conversation

Nuhvi
Copy link
Collaborator

@Nuhvi Nuhvi commented Feb 9, 2024

closes #6

@dvc94ch does this look good?

Copy link

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the issue is a local one which only happens when running in a docker container on macos, but having some logs will definitely help

@Nuhvi
Copy link
Collaborator Author

Nuhvi commented Feb 9, 2024

@dvc94ch Added Nuhvi@4f2e1b1 to log an error when mainline fails to populate the routing table, which most likely what is happening in docker because it is firewalled.

@Nuhvi Nuhvi requested a review from dvc94ch February 9, 2024 17:21
@dvc94ch
Copy link

dvc94ch commented Feb 9, 2024

Thanks!

@Nuhvi Nuhvi merged commit 14c67f2 into main Feb 9, 2024
1 check passed
@Nuhvi Nuhvi deleted the feat/tracing branch April 15, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors need to be logged.
2 participants