Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mint hooks to vending minter #628

Closed

Conversation

shanev
Copy link
Member

@shanev shanev commented Dec 4, 2023

No description provided.

Copy link

linear bot commented Dec 4, 2023

@shanev shanev self-assigned this Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

Cosm-Orc Gas Usage

Contract Op Name Gas Used Old Gas Used Gas Diff File
multiple_contracts Execute__minter_batch_exec_mint_token 1584889 18825195 -91.5810% e2e/src/tests/open_edition_minter_executes_tests.rs:142
vending_minter Store__Store 9220752 8839098 +4.3178% e2e/src/helpers/chain.rs:78
Raw Report for 8adccf0
Contract Op Name Gas Used Gas Wanted File
open_edition_factory Instantiate__factory_inst 186484 256610 e2e/src/helpers/open_edition_minter_helpers.rs:39
open_edition_factory Execute__factory_exec_minter_inst 542162 790118 e2e/src/tests/open_edition_minter_executes_tests.rs:59
open_edition_factory Execute__factory_exec_minter_inst_w_trading_time 542877 791190 e2e/src/tests/open_edition_factory_and_mint_tests.rs:405
open_edition_factory Store__Store 3469044 5180426 e2e/src/helpers/chain.rs:78
vending_factory Instantiate__factory_inst 187243 257748 e2e/src/helpers/helper.rs:35
vending_factory Execute__factory_exec_minter_inst 34037939 51033687 e2e/src/tests/factory_test.rs:98
vending_factory Execute__factory_exec_minter_inst_w_trading_time 3858140 5764010 e2e/src/tests/factory_test.rs:244
vending_factory Store__Store 3067318 4577837 e2e/src/helpers/chain.rs:78
multiple_contracts Execute__minter_batch_exec_mint_token 1584889 2354454 e2e/src/tests/open_edition_minter_executes_tests.rs:142
multiple_contracts Execute__minter_batch_exec_mint_token_w_trading_time 1956896 2904534 e2e/src/tests/factory_test.rs:314
minter Execute__minter_exec_mint_to_token 363984 522854 e2e/src/tests/open_edition_minter_executes_tests.rs:180
minter Execute__minter_exec_purge 139023 185466 e2e/src/tests/open_edition_minter_executes_tests.rs:281
minter Execute__minter_exec_update_per_addr_limit 209132 290579 e2e/src/tests/open_edition_minter_executes_tests.rs:216
minter Execute__minter_exec_update_trading_time 271319 383859 e2e/src/tests/open_edition_minter_executes_tests.rs:99
base_factory Store__Store 2688056 4008944 e2e/src/helpers/chain.rs:78
base_minter Store__Store 7008685 10489827 e2e/src/helpers/chain.rs:78
open_edition_minter Store__Store 8508482 12739523 e2e/src/helpers/chain.rs:78
sg721_base Store__Store 8395174 12569561 e2e/src/helpers/chain.rs:78
sg721_metadata_onchain Store__Store 8824616 13213724 e2e/src/helpers/chain.rs:78
sg721_nt Store__Store 7794873 11669109 e2e/src/helpers/chain.rs:78
sg721_updatable Store__Store 9187908 13758657 e2e/src/helpers/chain.rs:78
sg_whitelist Store__Store 3603321 5381841 e2e/src/helpers/chain.rs:78
sg_whitelist_flex Store__Store 3539283 5285784 e2e/src/helpers/chain.rs:78
vending_minter Store__Store 9220752 13807928 e2e/src/helpers/chain.rs:78
vending_minter_wl_flex Store__Store 9037322 13532783 e2e/src/helpers/chain.rs:78
whitelist_immutable Store__Store 2197332 3272858 e2e/src/helpers/chain.rs:78

@shanev shanev force-pushed the shanev/sg-578-add-mint-hook-to-fire-when-a-mint-happens branch from 2d34d08 to a65e308 Compare December 4, 2023 03:40
@shanev shanev marked this pull request as ready for review December 4, 2023 04:48
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (f4f6e82) 60.07% compared to head (8adccf0) 60.47%.

Files Patch % Lines
contracts/minters/vending-minter/src/contract.rs 76.47% 8 Missing ⚠️
packages/mint-hooks/derive/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   60.07%   60.47%   +0.40%     
==========================================
  Files          83       83              
  Lines        4518     4516       -2     
==========================================
+ Hits         2714     2731      +17     
+ Misses       1804     1785      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants