Added status and type to Membership. JS Chat release. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkal-pubnub
reviewed
Jan 7, 2025
| @@ -333,7 +333,7 @@ class ChannelIntegrationTest : BaseChatIntegrationTest() { | |||
| fun shouldReturnUserSuggestions_whenNoDataInCacheButUserAvailableInChat() = runTest { | |||
| // given | |||
| val userName = "userName_${someUser.id}" | |||
| val user: User = chat.createUser(id = someUser.id, name = userName).await() | |||
| val user = chat.createUser(id = someUser.id, name = userName).await() | |||
There was a problem hiding this comment.
instead of making random changes to source code just edit the RELEASE file that I put in the root project directory, for example:
echo `date` > RELEASE
wkal-pubnub
approved these changes
Jan 7, 2025
|
@pubnub-release-bot release js as 0.10.0 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added status and type to Membership.