Merge pull request #14 from pubnub/CE-3278-DeleteMessagesFix

delete messages fix
pubnub · Aug 23, 2018 · bf7cf82 · bf7cf82
2 parents 7b2492e + dd5e0d1
commit bf7cf82
Show file tree

Hide file tree

Showing 29 changed files with 427 additions and 170 deletions.
diff --git a/.pubnub.yml b/.pubnub.yml
@@ -1,81 +1,88 @@
 --- 
 changelog: 
-   -
+  - 
+    changes: 
+      - 
+        text: "Delete Messages Fix"
+        type: improvement
+    date: "Aug 23, 18"
+    version: v4.0.2
+  - 
     changes: 
       - 
         text: "Integration tests fixes"
         type: improvement
-    date: Mar 8, 18
+    date: "Mar 8, 18"
     version: v4.0.1
-   -
+  - 
     changes: 
       - 
         text: "Here Now Refresh"
         type: improvement
-    date: Feb 28, 18
+    date: "Feb 28, 18"
     version: v4.0-rc2
-   -
+  - 
     changes: 
       - 
-        text: "Cleanup"
+        text: Cleanup
         type: improvement
-    date: Jan 22, 18
+    date: "Jan 22, 18"
     version: v4.0-beta6
-   -
+  - 
     changes: 
       - 
         text: "Logging enhancements"
         type: improvement
-    date: Jan 18, 18
-    version: v4.0-beta5 
-   -
+    date: "Jan 18, 18"
+    version: v4.0-beta5
+  - 
     changes: 
       - 
-        text: "Cleanup"
+        text: Cleanup
         type: improvement
-    date: Jan 16, 18
-    version: v4.0-beta4 
-   -
+    date: "Jan 16, 18"
+    version: v4.0-beta4
+  - 
     changes: 
       - 
         text: "Windows Universal compatibility"
         type: improvement
-    date: Jan 11, 18
-    version: v4.0-beta3 
-   -
+    date: "Jan 11, 18"
+    version: v4.0-beta3
+  - 
     changes: 
       - 
         text: "Leave fixes"
         type: improvement
-    date: Dec 26, 17
-    version: v4.0-beta2 
-  -
+    date: "Dec 26, 17"
+    version: v4.0-beta2
+  - 
     changes: 
       - 
         text: "All new PubNub Unity SDK"
         type: improvement
-    date: Dec 11, 17
+    date: "Dec 11, 17"
     version: v4.0-beta1
   - 
     changes: 
       - 
         text: "Presence delta intervals"
         type: improvement
-    date: Dec 18, 17
+    date: "Dec 18, 17"
     version: v3.7.10
   - 
     changes: 
       - 
         text: "Unity UWP compatibility"
         type: improvement
-    date: Aug 8, 17
+    date: "Aug 8, 17"
     version: v3.7.9
   - 
     changes: 
       - 
         text: "Presence delta intervals"
         type: improvement
-    date: Mar 31, 17
+    date: "Mar 31, 17"
     version: v3.7.8
   - 
     changes: 
@@ -85,21 +92,21 @@ changelog:
       - 
         text: "Prefix UUID with 'pn-'"
         type: improvement
-    date: Feb 20, 17
+    date: "Feb 20, 17"
     version: v3.7.7
   - 
     changes: 
       - 
         text: "Fixed user state issue for other UUID"
         type: bug
-    date: Jan 12, 17
+    date: "Jan 12, 17"
     version: v3.7.6.2
   - 
     changes: 
       - 
         text: "Changed origin to ps.pndsn.com"
         type: feature
-    date: Dec 21, 16
+    date: "Dec 21, 16"
     version: v3.7.6.1
   - 
     changes: 
@@ -109,7 +116,7 @@ changelog:
       - 
         text: "Find out which UUID sent the message (only avialable when debug symbol `PUBNUB_PS_V2_RESPONSE` is used)."
         type: feature
-    date: Dec 9, 16
+    date: "Dec 9, 16"
     version: v3.7.6
   - 
     changes: 
@@ -129,7 +136,7 @@ changelog:
       - 
         text: "Added a debug symbol `PUBNUB_PS_V2_RESPONSE` to enable v4 subscribe"
         type: feature
-    date: Sep 24, 16
+    date: "Sep 24, 16"
     version: v3.7.4
   - 
     changes: 
@@ -155,7 +162,7 @@ changelog:
       - 
         text: "Code optimizations"
         type: improvement
-    date: Aug 2, 16
+    date: "Aug 2, 16"
     version: v3.7.2
   - 
     changes: 
@@ -165,7 +172,7 @@ changelog:
       - 
         text: "For iOS if the value of NonSubscribeTimeout and SubscribeTimeout is greater than 59 secs, the SDK will force the value to be 59 secs."
         type: improvement
-    date: Jun 21, 16
+    date: "Jun 21, 16"
     version: v3.6.9.1
   - 
     changes: 
@@ -177,9 +184,9 @@ changelog:
         type: improvement
       - 
         text: |
-            `Logging: In addition to setting the variables PubnubLogLevel = LoggingMethod.Level.Info and PubnubErrorLevel = PubnubErrorFilter.Level.Info you also need to add a "define symbol": ENABLE_PUBNUB_LOGGING for each of the platform you want to enable logging. 
+            `Logging: In addition to setting the variables PubnubLogLevel = LoggingMethod.Level.Info and PubnubErrorLevel = PubnubErrorFilter.Level.Info you also need to add a "define symbol": ENABLE_PUBNUB_LOGGING for each of the platform you want to enable logging.
             
-            This setting is available in the Unity Editor: File-> Build Settings -> Player Settings -> Other Settings -> Configuration -> Scripting define symbols. 
+            This setting is available in the Unity Editor: File-> Build Settings -> Player Settings -> Other Settings -> Configuration -> Scripting define symbols.
             After you type ENABLE_PUBNUB_LOGGING in it do remember to press return with the focus still in the text box or your setting will not be saved.
             `
         type: improvement
@@ -248,6 +255,8 @@ features:
     - CHANNEL-GROUPS-REMOVE-CHANNELS
     - CHANNEL-GROUPS-REMOVE-GROUPS
     - CHANNEL-GROUPS-LIST-CHANNELS-IN-GROUP
+  others: 
+    - TELEMETRY
   presence: 
     - PRESENCE-HERE-NOW
     - PRESENCE-WHERE-NOW
@@ -287,24 +296,22 @@ features:
     - REQUEST-MESSAGE-COUNT-EXCEEDED
   time: 
     - TIME-TIME
-  others:
-    - TELEMETRY 
-supported-platforms:
-  - 
-    version: PubNub Unity SDK
-    platforms:
-      - iOS player, will require iOS 7.0 or higher.
-      - Android, OS 2.3.1 or later; ARMv7 (Cortex) CPU with NEON support or Atom CPU; OpenGL ES 2.0 or later.
-      - Windows Phone, 8.1 or later.
-      - Windows Store Apps, 8.1 or later.
-      - WebGL, Any recent desktop version of Firefox, Chrome, Edge or Safari.
-      - Windows 7+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support.
-      - Ubuntu 12.04+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support.
-      - Mac OS X 10.8+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support.
-    editors:
-      - Unity 5.5.1
-      - Unity 2017.3.0f3
 name: unity
 schema: 1
 scm: github.com/pubnub/unity
-version: "v4.0.1"
+supported-platforms: 
+  - 
+    editors: 
+      - "Unity 5.5.1"
+      - "Unity 2017.3.0f3"
+    platforms: 
+      - "iOS player, will require iOS 7.0 or higher."
+      - "Android, OS 2.3.1 or later; ARMv7 (Cortex) CPU with NEON support or Atom CPU; OpenGL ES 2.0 or later."
+      - "Windows Phone, 8.1 or later."
+      - "Windows Store Apps, 8.1 or later."
+      - "WebGL, Any recent desktop version of Firefox, Chrome, Edge or Safari."
+      - "Windows 7+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support."
+      - "Ubuntu 12.04+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support."
+      - "Mac OS X 10.8+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support."
+    version: "PubNub Unity SDK"
+version: v4.0.2
diff --git a/PubNubUnity/Assets/Builders/History/DeleteMessagesRequestBuilder.cs b/PubNubUnity/Assets/Builders/History/DeleteMessagesRequestBuilder.cs
@@ -39,6 +39,13 @@ public void Async(Action<PNDeleteMessagesResult, PNStatus> callback)
                 return;
             }
 
+            if(string.IsNullOrEmpty(this.PubNubInstance.PNConfig.SecretKey)){
+                PNStatus pnStatus = base.CreateErrorResponseFromMessage("SecretKey is required", null, PNStatusCategory.PNBadRequestCategory);
+                Callback(null, pnStatus);                
+
+                return;
+            }
+
             base.Async(this);
         }