Index from Figgy. #167
Index from Figgy. #167
Conversation
tpendragon
force-pushed
the
figgy_reindex
branch
from
c5a16ed to
f041326
Compare
| { | ||
| "@id":"https://figgy.princeton.edu/catalog/a51c7f0b-4203-4ae9-b063-3e03fac1832b", | ||
| "@type":"skos:Concept", | ||
| "pref_label":"Advertising--Tourism", |
There was a problem hiding this comment.
I think this is a separate issue, but this looks like a new wrinkle on the subject/category display issue. Should this display as "Tourism--Advertising" or "Advertising--Tourism" or something else?
There was a problem hiding this comment.
I understood this to be the actual subject, such that the combined category / subject would be "Tourism -- Advertising--Tourism".
There was a problem hiding this comment.
That seems silly to me. But it's possible that is how it should be displayed, or that this is just a data problem — there are two other terms in that vocab that have dashes in them (Tourism--Economic aspects
Tourism--Social aspects).
I'll create a separate issue to handle those, and not worry about the display of these terms until we resolve that.
There was a problem hiding this comment.
This is the label as it exists in the LAE Subjects fixture, so I think that's a call for them.
There was a problem hiding this comment.
I've created pulibrary/figgy#456 to track this.
| end | ||
| it "converts the JSON-LD into a suitable solr document" do | ||
| stub_plum_jsonld(record: "b9e8325e-baf2-45e4-b32c-5e5b3755c8ef") |
There was a problem hiding this comment.
I've created a ticket to stop using VCR instead of doing some VCR and some webmock stubbing: #168
Closes #161, closes #158