Add LIMIT statement to those queries needed during Pulp startup process. #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current query can be super heavy in environments with lots of packages and really slow down the startup process of Pulp components. Since we're checking the presence of any number of artifacts using a certain checksum, limiting it to the first result can speed up the check itself and the startup process.
decko
force-pushed
the
limit_checksum_startup_check
branch
from
1549aab to
72778a8
Compare
dralley
reviewed
Feb 12, 2025
| cursor.execute(f"SELECT count(pulp_id) FROM core_artifact WHERE {checksum} IS NULL") | ||
| cursor.execute( | ||
| f"SELECT count(pulp_id) FROM core_artifact WHERE {checksum} IS NULL LIMIT 1" | ||
| ) |
There was a problem hiding this comment.
Wouldn't EXISTS be a bit simpler?
There was a problem hiding this comment.
Isn't EXISTS a subquery operator? https://www.postgresql.org/docs/current/functions-subquery.html#FUNCTIONS-SUBQUERY-EXISTS
How could we use it in this context?
There was a problem hiding this comment.
Never mind, the django .exists() doesn't map to the SQL concept of EXISTS as I thought it did.
ggainey
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current query can be super heavy in environments with lots of
packages and really slow down the startup process of Pulp components.
Since we're checking the presence of any number of artifacts using a
certain checksum, limiting it to the first result can speed up the
check itself and the startup process.