Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Fix libyaml github URL and name for libyaml file #740

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

traylenator
Copy link
Contributor

The github path was incorrect and the 0.2.5 was being included twice resulting in:

Attempting to fetch from canonical URL "https://github.com/yaml/libyaml/releases/download/libyaml/yaml-0.2.5-0.2.5.tar.gz"
An error was encountered evaluating block. Retrying..

Will only be seen with - VANAGON_USE_MIRRORS=false

The github path was incorrect and the 0.2.5 was being included twice resulting in:

```
Attempting to fetch from canonical URL "https://github.com/yaml/libyaml/releases/download/libyaml/yaml-0.2.5-0.2.5.tar.gz"
An error was encountered evaluating block. Retrying..
```

Will only be seen with - `VANAGON_USE_MIRRORS=false`
@traylenator traylenator requested review from a team as code owners October 18, 2023 18:38
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

traylenator added a commit to cernops/puppet-runtime that referenced this pull request Oct 18, 2023
puppetlabs-toy-chest#740

Correct the github path to libyaml releases.

The 0.2.5 was being included twice as well.

```
Attempting to fetch from canonical URL "https://github.com/yaml/libyaml/releases/download/libyaml/yaml-0.2.5-0.2.5.tar.gz"
An error was encountered evaluating block. Retrying..
```

Will only be seen with `VANAGON_USE_MIRRORS='false'`
@traylenator
Copy link
Contributor Author

CLA signed between CERN IT and Puppetlabs.

Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ bx rake vanagon:component_diff -- -p el-7-x86_64 --from upstream/master --to HEAD 
...
Here is what your code changes would affect:

Project agent-runtime-main

Platform name: el-7-x86_64
    Component 'libyaml'
        Field: url
        --------------------
        - https://github.com/yaml/libyaml/releases/download/libyaml/yaml-0.2.5-0.2.5.tar.gz
        + https://github.com/yaml/libyaml/releases/download/0.2.5/yaml-0.2.5.tar.gz

where

$ curl -sLI https://github.com/yaml/libyaml/releases/download/libyaml/yaml-0.2.5-0.2.5.tar.gz | grep HTTP/
HTTP/2 404
$ curl -sLI https://github.com/yaml/libyaml/releases/download/0.2.5/yaml-0.2.5.tar.gz | grep HTTP/
HTTP/2 302 
HTTP/2 200 

@joshcooper joshcooper merged commit 46aa77a into puppetlabs-toy-chest:master Oct 19, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants