(PA-5925) rectified option in openssl1.1.1

[amitkarsale]

rectified the compiler option.

[amitkarsale]

Vanagon generic builder : https://jenkins-platform.delivery.puppetlabs.net/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/BUILD_TARGET=aix-7.2-ppc,SLAVE_LABEL=k8s-worker/2490/console

[joshcooper]

Were you able to build the runtime with this change? The reason I ask is I'm not used to seeing spaces between -Wl and the rest:

Suggested change

	ldflags = "#{settings[:ldflags]} -Wl, -R#{settings[:libdir]}"
	ldflags = "#{settings[:ldflags]} -Wl,-R#{settings[:libdir]}"

The idea is -Wl tells gcc to pass the arguments that directly follow to the linker. But if there's a space after the comma it may not work as expected?

[joshcooper]

Yeah the space doesn't work:

Makefile:111: recipe for target 'openssl-1.1.1-build' failed
gcc: error: unrecognized command line option '-R'
gmake[2]: *** [apps/app_rand.o] Error 1
gmake[1]: *** [all] Error 2
gmake: *** [openssl-1.1.1-build] Error 2

So I force pushed to your branch. It looks like your vanagon generic builder jobs built agent-runtime-main which uses openssl 3 so it didn't catch the problem.

[amitkarsale]

I am new to using gcc command options. For other commands I used spaces between the options so took it casually. thanks for catching this Josh! B-)

[joshcooper]

# dump -H -X32 /opt/puppetlabs/puppet/bin/openssl 

/opt/puppetlabs/puppet/bin/openssl:

                        ***Loader Section***
                      Loader Header Information
VERSION#         #SYMtableENT     #RELOCent        LENidSTR
0x00000001       0x0000067a       0x00001875       0x00000099       

#IMPfilID        OFFidSTR         LENstrTBL        OFFstrTBL
0x00000006       0x0001c10c       0x000078d8       0x0001c1a5       


                        ***Import File Strings***
INDEX  PATH                          BASE                MEMBER              
0      /opt/puppetlabs/puppet/lib:/usr/lib:/lib                                         
1                                    libssl.a            libssl.so.1.1       
2                                    libcrypto.a         libcrypto.so.1.1    
3                                    libpthreads.a       shr_xpg5.o          
4                                    libc.a              shr.o               
5                                    librtl.a            shr.o