This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
(maint) Add design decision for recent pdk-runtime PR #758 #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Didrichsen <[email protected]>
gavindidrichsen
force-pushed
the
add_design_decision_for_pdk
branch
from
6961c5b to
b2a9a87
Compare
Signed-off-by: Gavin Didrichsen <[email protected]>
gavindidrichsen
force-pushed
the
add_design_decision_for_pdk
branch
from
7fa2793 to
d5036ad
Compare
|
I'm generally in favor of documenting why things are the way we are for the next poor soul that has to work on the runtime. For example, I have this PR up #717 I think my only question is we already have a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to answer why and how this pdk-runtime PR attempted to address a critical issue stemming from a homebrew update causing a version mismatch in OpenSSL libraries and headers within pdk-runtime.
As there seems to be more potential changes required to compensate for the impact of the homebrew update I'm moving this to Draft until testing is complete.