This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
(maint) Use the intended vanagon config file when building SPARC #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2024
cthorn42
force-pushed
the
maint/master/use_vanagon-config_for_sparc
branch
from
ebf615a to
cd0df2d
Compare
joshcooper
reviewed
Jul 31, 2024
| @@ -41,7 +41,9 @@ | |||
| basedir=default" > /var/tmp/vanagon-noask; | |||
| echo "mirror=https://artifactory.delivery.puppetlabs.net/artifactory/generic__remote_opencsw_mirror/testing" > /var/tmp/vanagon-pkgutil.conf; | |||
| pkgadd -n -a /var/tmp/vanagon-noask -d http://get.opencsw.org/now all | |||
| /opt/csw/bin/pkgutil -U && /opt/csw/bin/pkgutil -y -i gcc4g++ bison CSWxz-5.2.8,REV=2022.11.16 || exit 1 | |||
| # See PA-6877 for why gcc4g++ needs to be installed seperately from the other packages | |||
| /opt/csw/bin/pkgutil -U && /opt/csw/bin/pkgutil -y -i gcc4g++ | |||
There was a problem hiding this comment.
One nit, previously all of the pkgutil commands were chained together with && so if any of them failed, we fall back to exit 1.
Suggested change
| /opt/csw/bin/pkgutil -U && /opt/csw/bin/pkgutil -y -i gcc4g++ | |
| /opt/csw/bin/pkgutil -U && /opt/csw/bin/pkgutil -y -i gcc4g++ && \ |
The \ is needed since the lines span multiple lines. Or you could put it all on one long line.
Also should we be passing the conf file with the -U command?
/opt/csw/bin/pkgutil -config=/var/tmp/vanagon-pkgutil.conf -U && ...
cd0df2d to
29b488b
Compare
|
agent-runtime-main link: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/3138/ (there is a failing osx12-arm cell that was fixed in a different PR) |
joshcooper
approved these changes
Aug 2, 2024
AriaXLi
added
the
maintenance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.