This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
(PE-38998) Revert ffi bump #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The puppet gem constrians ffi to < 1.17 for now. This commit reverts the 1.17 bump.
joshcooper
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
$ bundle exec rake vanagon:component_diff -- -P all -p el-9-x86_64 --from upstream/master --to HEAD
⚠️ DISCLAIMER
This task is still experimental, it can be invoked locally provided that
development dependencies are installed (bundle install --with development).
Ensure all your local changes are committed, then run
bundle exec rake vanagon:component_diff -- [options].
Run the task with --help to see all available options. If you notice unexpected
behavior or want to suggest improvements, ping #prod-puppet-agent on Slack.
Here is what your code changes would affect:
Project pe-installer-runtime-main
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/installer/bin/gem install --no-document --local --bindir=/opt/puppetlabs/installer/bin ffi-1.17.0.gem -- --enable-system-libffi
+ /opt/puppetlabs/installer/bin/gem install --no-document --local --bindir=/opt/puppetlabs/installer/bin ffi-1.16.3.gem -- --enable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Project pe-bolt-server-runtime-main
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/server/apps/bolt-server/bin/gem install --no-document --local --bindir=/opt/puppetlabs/server/apps/bolt-server/bin ffi-1.17.0.gem -- --enable-system-libffi
+ /opt/puppetlabs/server/apps/bolt-server/bin/gem install --no-document --local --bindir=/opt/puppetlabs/server/apps/bolt-server/bin ffi-1.16.3.gem -- --enable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Project agent-runtime-7.x
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/puppet/bin/gem install --no-document --local ffi-1.17.0.gem -- --disable-system-libffi
+ /opt/puppetlabs/puppet/bin/gem install --no-document --local ffi-1.16.3.gem -- --disable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Project pe-bolt-server-runtime-2021.7.x
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/puppet/bin/gem install --no-document --local --bindir=/opt/puppetlabs/server/apps/bolt-server/bin ffi-1.17.0.gem -- --disable-system-libffi
+ /opt/puppetlabs/puppet/bin/gem install --no-document --local --bindir=/opt/puppetlabs/server/apps/bolt-server/bin ffi-1.16.3.gem -- --disable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Project pe-installer-runtime-2021.7.x
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/installer/bin/gem install --no-document --local --bindir=/opt/puppetlabs/installer/bin ffi-1.17.0.gem -- --disable-system-libffi
+ /opt/puppetlabs/installer/bin/gem install --no-document --local --bindir=/opt/puppetlabs/installer/bin ffi-1.16.3.gem -- --disable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Project bolt-runtime
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/bolt/bin/gem install --no-document --local --bindir=/opt/puppetlabs/bolt/bin ffi-1.17.0.gem -- --disable-system-libffi
+ /opt/puppetlabs/bolt/bin/gem install --no-document --local --bindir=/opt/puppetlabs/bolt/bin ffi-1.16.3.gem -- --disable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Project pdk-runtime
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/pdk/private/ruby/3.2.5/bin/gem install --no-document --local ffi-1.17.0.gem -- --enable-system-libffi
+ /opt/puppetlabs/pdk/private/ruby/3.2.5/bin/gem install --no-document --local ffi-1.16.3.gem -- --enable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Project client-tools-runtime-main
Nothing is affected 😊
Project client-tools-runtime-2021.7.x
Nothing is affected 😊
Project agent-runtime-main
Platform name: el-9-x86_64
Component 'rubygem-ffi'
Field: install[0]
--------------------
- /opt/puppetlabs/puppet/bin/gem install --no-document --local ffi-1.17.0.gem -- --enable-system-libffi
+ /opt/puppetlabs/puppet/bin/gem install --no-document --local ffi-1.16.3.gem -- --enable-system-libffi
Field: mirrors[0]
--------------------
- https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.17.0.gem
+ https://artifactory.delivery.puppetlabs.net/artifactory/generic/buildsources/ffi-1.16.3.gem
Field: options|sum
--------------------
- 51630e43425078311c056ca75f961bb3bda1641ab36e44ad4c455e0b0e4a231c
+ 6d3242ff10c87271b0675c58d68d3f10148fabc2ad6da52a18123f06078871fb
Field: url
--------------------
- https://rubygems.org/downloads/ffi-1.17.0.gem
+ https://rubygems.org/downloads/ffi-1.16.3.gem
Field: version
--------------------
- 1.17.0
+ 1.16.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The puppet gem constrians ffi to < 1.17 for now. This commit reverts the 1.17 bump.