Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cat 1910 fix nightlies same #356

Closed
wants to merge 3 commits into from
Closed

Cat 1910 fix nightlies same #356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9756262
All rubocop gems the same
gavindidrichsen Jun 19, 2024
efcaf0c
Pin the gems.
gavindidrichsen Jun 19, 2024
fc66973
Update
gavindidrichsen Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,10 @@ group :tests do

# Split the rubocop versions to avoid conflicts.
# (*) Why is jruby included? See docs/adr/0001-test-the-resource-api-again-jruby-as-well-as-ruby-engines.md
# (*) Why are jruby dependencies different from ruby? See docs/adr/0002-split-gemfile-dependencies-by-jruby-and-ruby-engines.md
if RUBY_ENGINE == 'jruby'
gem 'rubocop', '~> 1.48.1', require: false
gem 'rubocop-rspec', '~> 2.20.0', require: false
gem 'rubocop-performance', '~> 1.17.1', require: false
else
gem 'rubocop', '~> 1.64.1', require: false
gem 'rubocop-rspec', '~> 3.0', require: false
gem 'rubocop-performance', '~> 1.16', require: false
end
# (*) Why should we keep these dependencies pinned as below? See docs/adr/0002-split-gemfile-dependencies-by-jruby-and-ruby-engines.md
gem 'rubocop', '~> 1.48.1', require: false
gem 'rubocop-rspec', '~> 2.20.0', require: false
gem 'rubocop-performance', '~> 1.17.1', require: false
end

group :development do
Expand Down