Add String.matches to additional string methods #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2021 11:33
# Conflicts: # airspeed/__init__.py
|
@purcell , any chance to merge and release this reasonably soon? |
purcell
reviewed
Dec 8, 2023
airspeed/__init__.py
Outdated
| @@ -36,8 +37,9 @@ | |||
| 'add': lambda self, value: self.append(value) | |||
| }, | |||
| dict: { | |||
| 'isEmpty': lambda self: self == {}, | |||
There was a problem hiding this comment.
I suspect this might be more idiomatic/safer, perhaps, in cases of weird subclassing?
Suggested change
| 'isEmpty': lambda self: self == {}, | |
| 'isEmpty': lambda self: bool(self), |
There was a problem hiding this comment.
Your probably meant not bool(self)? Alternatively we could do len(self) == 0. I do not have a strong opinion here. Pushing the bool solution.
|
Thanks, merged and released as 0.6.0 |
|
Apologies for the long wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another small additional string method.