Surface entire Lightning Time object in clock hook #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
useLightningTimeClock()
hook only surfaces two strings:lightningTimeClock
andnormalTimeClock
. A new Hack Night dashboard implementation changes the color of each part, and the person who wrote that dashboard wrote their own implementation of Lightning Time to make it work. I realized that in order to achieve the same thing with this library, you would have to re-implement logic that is already in this library but not surfaced in the clock.This PR surfaces the entire Lightning Time object in the
useLightningTimeClock()
hook.Before:
After:
This is a breaking API change, which would technically warrant a new major version
1.0.0
, but if I merge this I will ignore semver because I want to save 1.0.0 for an API overhaul and I know for sure nobody other than me is using the clock in production.