Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use node prefix imports #24

Merged
merged 2 commits into from
Jan 9, 2025
Merged

chore: use node prefix imports #24

merged 2 commits into from
Jan 9, 2025

Conversation

emattiza
Copy link
Contributor

@emattiza emattiza commented Jan 7, 2025 •
edited
Loading

Description of the change

change import to be prefixed with node: to indicate builtin module usage

see Node Docs on Builtin Modules for reference. This change is live for all node versions >16, which is before current earliest LTS release of 18.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@emattiza
chore: use node prefix imports
05f91cd 
change import to be prefixed with node: to indicate builtin
module usage
@emattiza
add changelog entry
a1cf3a0
@thomashoneyman thomashoneyman merged commit 2d03799 into purescript-node:master Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emattiza @garyb @thomashoneyman