Code

Refactor settings and related code#2660

Code

Merged

pfps merged 28 commits intopwr-Solaar:masterpwr-Solaar/Solaar:masterfrom MattHag:refactor_settingsMattHag/Solaar:refactor_settingsCopy head branch name to clipboardJan 1, 2025

+1,907-1,595

Commits

Commits on Dec 24, 2024

• Split up huge settings module

  Show description for a2021ba
  MattHag

  committed
  a2021ba

  Copy full SHA for a2021ba

• Refactor: Convert Kind to IntEnum

  Show description for b0599e7
  MattHag

  committed
  b0599e7

  Copy full SHA for b0599e7

Commits on Jan 1, 2025

• type hints: Introduce settings protocol

  Show description for cc743b8
  MattHag

  committed
  cc743b8

  Copy full SHA for cc743b8

• Refactor: Remove diversion alias

  Show description for 9dbd368
  MattHag

  committed
  9dbd368

  Copy full SHA for 9dbd368

• Simplify settings UI class

  Show description for 6869f19
  MattHag

  committed
  6869f19

  Copy full SHA for 6869f19

• Enforce rules on RuleComponentUI subclasses

  Show description for aff2872
  MattHag

  committed
  aff2872

  Copy full SHA for aff2872

• settings: Add docstrings and type hint

  Show description for 4213a1a
  MattHag

  committed
  4213a1a

  Copy full SHA for 4213a1a

• Remove NamedInts: Convert Column to enum

  Show description for 6207ff1
  MattHag

  committed
  6207ff1

  Copy full SHA for 6207ff1

• Remove NamedInts: Convert Task to enum

  Show description for 9a60d65
  MattHag

  committed
  9a60d65

  Copy full SHA for 9a60d65

• Add type hints

  Show description for e412279
  MattHag

  committed
  e412279

  Copy full SHA for e412279

• key flags: Move to module of use

  Show description for 8d8d540
  MattHag

  committed
  8d8d540

  Copy full SHA for 8d8d540

• Add type hints

  Show description for 6c4612f
  MattHag

  committed
  6c4612f

  Copy full SHA for 6c4612f

• Remove NamedInts: Convert KeyFlag to Flag

  Show description for f1ee1c4
  MattHag

  committed
  f1ee1c4

  Copy full SHA for f1ee1c4

• Remove NamedInts: Convert Spec to enum

  Show description for 3f0d3ed
  MattHag

  committed
  3f0d3ed

  Copy full SHA for 3f0d3ed

• Remove NamedInts: Convert ActionId to enum

  Show description for 41ac048
  MattHag

  committed
  41ac048

  Copy full SHA for 41ac048

• mapping flag: Move to module of use

  Show description for 729c713
  MattHag

  committed
  729c713

  Copy full SHA for 729c713

• Remove NamedInts: Convert MappingFlag to flag

  Show description for 3bee2b1
  MattHag

  committed
  3bee2b1

  Copy full SHA for 3bee2b1

• Remove NamedInts: Convert PowerSwitchLocation to flag

  Show description for 6d51b22
  MattHag

  committed
  6d51b22

  Copy full SHA for 6d51b22

• Remove NamedInts: Convert HorizontalScroll to enum

  Show description for b9154bf
  MattHag

  committed
  b9154bf

  Copy full SHA for b9154bf

• Remove NamedInts: Convert LedRampChoice to flag

  Show description for 55b5c08
  MattHag

  committed
  55b5c08

  Copy full SHA for 55b5c08

• charge status: Refactor to enum and move to module of use

  Show description for 1aadc6c
  MattHag

  committed
  1aadc6c

  Copy full SHA for 1aadc6c

• Remove NamedInts: Convert LedFormChoices to enum

  Show description for 8d51658
  MattHag

  committed
  8d51658

  Copy full SHA for 8d51658

• Fix KeyFlag conversion

  MattHag

  committed
  726eedc

  Copy full SHA for 726eedc

• Fixes on top of refactoring

  MattHag

  committed
  de6d8b4

  Copy full SHA for de6d8b4

• Prepare refactoring of NotificationFlag

  Show description for ad9e65b
  MattHag

  committed
  ad9e65b

  Copy full SHA for ad9e65b

• Remove NamedInts: Convert NotificationFlag to flag

  Show description for dcf5460
  MattHag

  committed
  dcf5460

  Copy full SHA for dcf5460

• Remove NamedInts: Convert DeviceFeature to flag

  Show description for b42da96
  MattHag

  committed
  b42da96

  Copy full SHA for b42da96

• Refactor InfoSubRegisters: Use IntEnum in favour of NamedInts

  

  some_developer

  authored and

  MattHag

  committed
  5333e0d

  Copy full SHA for 5333e0d