Translate .desktop files with gettext #2719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A LINGUAS[1] file is necessary for gettext to work with .desktop files[2]. [1]: https://www.gnu.org/software/gettext/manual/html_node/po_002fLINGUAS.html [2]: https://www.gnu.org/software/gettext/manual/gettext.html#index-_002dd_002c-msgfmt-option-3
tomodachi94
force-pushed
the
desktop-gettext
branch
from
cda42ee to
aa20a20
Compare
|
Sounds good, but now conflicts with specific updates to translations so needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This encourages translators to translate these strings by including them with the other translations. It also keeps them in one spot, avoiding duplicating them between the two
.desktopfiles.Implementation
Changes made to incorporate this:
.py, which is consistent with the assumptions made in gettext.desktoptranslation)Also, migrated most of the existing translations in the
.desktopfiles. I didn't migratezh_HKbecause it doesn't have any other translations.Places for improvement
I am not fond of the
.template.desktopsetup; let me know if anyone thinks of a viable alternative.Sorry for the massive diff; that is a result of running
tools/update-po.shon the files I changed when moving the existing translations into the gettext ones.