Handle device open exceptions in hidapi and skip unsupported devices #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MattHag You'll have to check this PR out. |
MattHag
reviewed
Jan 2, 2025
MattHag
reviewed
Jan 2, 2025
MattHag
requested changes
Jan 2, 2025
|
I'm pretty sure the failed CI checks are unrelated to my changes |
MattHag
reviewed
Jan 2, 2025
MattHag
reviewed
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If VID and PID are both zero, the device is highly unlikely to be HID++ capable. On an Apple Silicon Mac, there are a lot of internal HID class devices on bus ID 0x0, none of which are what we are looking for. In both cases we shouldn't even attempt to open the devices at all.
Not all HID class devices found on the system can be opened,
open_path()will fail with an unhandled exceptionIOHIDDeviceGetReport failed: (0xE00002C7) (iokit/common) unsupported function. That has been fixed as well.Update gitignore to include common junk files generated by macOS, and pipenv config which this project doesn't use.