Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: #3118 - Unterminated object in _write_increment #3119

Closed
wants to merge 6 commits into from

Conversation

m32
Copy link
Contributor

@m32 m32 commented Feb 11, 2025

No description provided.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (2263dcb) to head (624078f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3119   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          53       53           
  Lines        8873     8873           
  Branches     1622     1622           
=======================================
  Hits         8564     8564           
  Misses        185      185           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Thanks. Could you please add a test for this as well?

@m32
Copy link
Contributor Author

m32 commented Feb 12, 2025

pypdf is not a validator, so making this one fix doesn't make sense.

I checked how pypdf works when there is no endobj tag at all - it works :)), evince also works but AcrobatReader shows error 109.

The following piece is an invalid pdf but pypdf ignores everything after loading first object and doesn't even touch the rest:
...
3 0 obj
<</Type /Page
/Parent 1 0 R
/Resources 2 0 R
/Contents 4 0 R>>
<<ojojoj 123>>
aa
4 0 obj
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants