something is wrong with the error

py4dstem · Jan 15, 2025 · fb7b6c5 · fb7b6c5
1 parent 0fb9234
commit fb7b6c5
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/py4DSTEM/tomography/tomography.py b/py4DSTEM/tomography/tomography.py
@@ -1481,10 +1481,10 @@ def _calculate_update(
         if dp_patterns.shape[0] == 0:
             update = xp.zeros(object_sliced.shape)
 
-            error = xp.mean(object_sliced.ravel() ** 2)
+            error = xp.mean(object_sliced.ravel() ** 2) ** 0.5
 
             error = copy_to_device(error, "cpu")
-
+            print("hello")
         else:
             weights = np.hstack(
                 [
@@ -1537,7 +1537,9 @@ def _calculate_update(
 
             update = dp_patterns_counted - object_sliced
 
-            error = xp.mean(update.ravel() ** 2)
+            error = (
+                xp.mean(update.ravel() ** 2) ** 0.5 / dp_patterns_counted.mean(0).sum()
+            )
 
             error = copy_to_device(error, "cpu")