Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diskdetection refactor #520

Draft
wants to merge 4,578 commits into
base: dev
Choose a base branch
from
Draft

Conversation

bsavitzky
Copy link
Member

This PR draft refactors find_Bragg_disks. Existing syntax is not affected, instead implementing a new method find_bragg_vectors in this draft.

The function call signature and docstring specifying behavior is currently complete. Logic is not yet implemented.

cophus and others added 30 commits July 13, 2023 14:49
…p and port to constraints tomorrow morning.

Former-commit-id: a7ee689
…ngle-slice, will do rest of the classes tomorrow.

Former-commit-id: c4f4b26
Former-commit-id: 2ebfb32
Former-commit-id: d693ed9
Former-commit-id: ab295ac
Former-commit-id: bde93c5
Former-commit-id: 884450d
Former-commit-id: bb09061
Former-commit-id: 4625d39
Former-commit-id: 5d973ea
Former-commit-id: 9174f0b
Former-commit-id: b0e1ac6
sezelt and others added 29 commits August 18, 2023 14:07
Updating whole pattern fitting for v 0.14.3

Former-commit-id: b51a392
Former-commit-id: a05f650
…ings

updating some docstrings

Former-commit-id: e57c41a
small changes to show

Former-commit-id: a188444
Former-commit-id: 2ccc7dd
Former-commit-id: e96a718
Former-commit-id: f0349bb
Former-commit-id: bfdb478
Former-commit-id: ca07ddb
older versions seem to have issues downloading some links so updating minimum version

Former-commit-id: 840cf3b
Updating gdown version to latest

Former-commit-id: b0fbf8c
Former-commit-id: 48c0924
Former-commit-id: cabb90b
nudging python version

Former-commit-id: 4d60318
CI/CD - Adding installation checkers 

Former-commit-id: fb01fa4
Add a GitHub action that checks for `black` styling

Former-commit-id: d9daf5d
Former-commit-id: 1c5800e
@bsavitzky bsavitzky force-pushed the diskdetection_refactor branch from 1c5800e to 348d4cc Compare March 12, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants