-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up benchmarks by removing dead code from work_precision_sets #4771
Clean up benchmarks by removing dead code from work_precision_sets #4771
Conversation
- Removed the entire work_precision_sets folder - Deleted all related dead code files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4771 +/- ##
========================================
Coverage 98.69% 98.69%
========================================
Files 303 303
Lines 23256 23258 +2
========================================
+ Hits 22953 22955 +2
Misses 303 303 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to get rid of the workflow files
I believe you're referring to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need to remove https://github.com/pybamm-team/PyBaMM/tree/develop/benchmarks/benchmark_images
Sorry missed that in my review |
Sure, I'll remove that as well. |
Head branch was pushed to by a user without write access
76c6508
@Saransh-cpp Is this one good now? |
@vidipsingh Lychee caught another error with your changes: |
…ybamm-team#4771) * remove dead code from benchmarks/work_precision_sets - Removed the entire work_precision_sets folder - Deleted all related dead code files * remove work_precision_sets workflow * remove benchmark_images folder from benchmarks * remove file --------- Co-authored-by: Agriya Khetarpal <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]>
Description
This PR removes the
benchmarks/work_precision_sets
folder, which contained dead code not currently in use by CI or other parts of the system. These files are supposed to be in the validation repository, which is not currently functioning. Removing them helps clean up unused parts of the codebase.Fixes: #4766
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest
(or$ nox -s tests
)$ python -m pytest --doctest-plus src
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: