-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list available backends and basic descriptors #7000
Conversation
for more information, see https://pre-commit.ci
I know that it is more work but I think it would be more beneficial to have this information formated nicely than simply returning some lists. |
Sounds good - I'll make that happen! |
Hey @JessicaS11! Nice to see you here. This is a going to be a great first-time contribution!
One approach might be to add a nice class BackendEntryPoint:
...
def __str__(self) -> str:
txt += self.backend_description
if self.backend_url:
txt += f"\nFind more info at {self.backend_url}"
return txt What might be clearer is if this backend class knew it's own name, but I'm not sure it can, hmmm |
That would not display in a nice table though. But might be anyway nice to add ;)
What about |
So what would the return type need to be to get a nice table representation, but also allow you to select out individual backend objects? A pandas object containing the backend objects? Some kind of
Correct me if I'm wrong, but if a subclassed |
You're right. But this mapping has to be somewhere. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Agreed. I added a
... I haven't dreamed up an answer to this question yet. We could set it up so that |
Looks like they are - every subclass of EDIT: (Actually we should wait to put tests in too really) |
Did you discuss adding |
In #7114 I have added this class attribute with default = True. Maybe we can merge this first? Which tests did you want to see? |
@JessicaS11 if you merge master and solve the conflicts this should be enough for a merge :) |
Couple of minor comments, then we can merge. |
@headtr1ck GitHub is unhelpfully not showing me any comments. Can you share a screen shot or something so I can address them? Thanks! |
Forgot to click the ok button, haha |
* main: Add import ASV benchmark (pydata#7176) Rework docs about scatter plots (pydata#7169) Fix some scatter plot issues (pydata#7167) Fix doctest warnings, enable errors in CI (pydata#7166) fix broken test (pydata#7168) Add typing to plot methods (pydata#7052) Fix warning in doctest (pydata#7165)
Co-authored-by: Mick <[email protected]>
This reverts commit fdd1346.
@headtr1ck the typing changes didn't work. Can you send in a separate PR for that please? |
Ok, weird. But can do :) |
Wanted to garner maintainer feedback on the basic implementation before I add any docs. I will need some guidance for adding tests.
whats-new.rst
api.rst