Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support searching observations by observation fields #473

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Support searching observations by observation fields #473

merged 1 commit into from
Mar 19, 2023

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Mar 8, 2023 •
edited
Loading

Closes #381

@JWCook JWCook added the enhancement New feature or request label Mar 8, 2023
@JWCook JWCook added this to the v0.19 milestone Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited
Loading

Codecov Report

Merging #473 (9d4c5f6) into main (e15cb25) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   95.08%   95.10%   +0.01%     
==========================================
  Files          57       57              
  Lines        3091     3103      +12     
  Branches      585      590       +5     
==========================================
+ Hits         2939     2951      +12     
  Misses        113      113              
  Partials       39       39
Impacted Files Coverage Δ
pyinaturalist/v1/observations.py 96.61% <ø> (ø)
pyinaturalist/converters.py 95.83% <100.00%> (ø)
pyinaturalist/docs/templates.py 100.00% <100.00%> (ø)
pyinaturalist/request_params.py 98.27% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JWCook JWCook force-pushed the search-by-obs-fields branch 2 times, most recently from 3d11380 to d46d3f6 Compare March 19, 2023 19:50
@JWCook JWCook force-pushed the search-by-obs-fields branch from d46d3f6 to 72b01ca Compare March 19, 2023 19:52
@JWCook JWCook marked this pull request as ready for review March 19, 2023 19:52
@JWCook JWCook force-pushed the search-by-obs-fields branch from 72b01ca to 9d4c5f6 Compare March 19, 2023 19:56
@JWCook JWCook merged commit 8329e2c into main Mar 19, 2023
@JWCook JWCook deleted the search-by-obs-fields branch March 19, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.

Support searching observations by observation fields
1 participant
@JWCook