Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/2.15.x] Restore setting a Call as a base for classes from six.with_metaclass() #2067

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport b5ebf99 from #2049.

…s` (#2049)

Harden support for using enums as metaclasses.

Fixes the crash in pylint-dev/pylint#5935 by adopting the check
for not-none bases as in ClassDef._inferred_bases without recausing
the false positive reported in pylint-dev/pylint#7506, which requires
correct bases.

(cherry picked from commit b5ebf99)
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #2067 (7aa5c2d) into maintenance/2.15.x (edf88c6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           maintenance/2.15.x    #2067      +/-   ##
======================================================
- Coverage               92.82%   92.82%   -0.01%     
======================================================
  Files                      95       95              
  Lines                   11067    11066       -1     
======================================================
- Hits                    10273    10272       -1     
  Misses                    794      794              
Flag Coverage Δ
linux 92.58% <100.00%> (-0.01%) ⬇️
pypy 88.18% <100.00%> (+<0.01%) ⬆️
windows 92.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/brain/brain_six.py 89.88% <ø> (-0.12%) ⬇️
astroid/nodes/scoped_nodes/scoped_nodes.py 93.07% <100.00%> (ø)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 054455a into maintenance/2.15.x Mar 26, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-2049-to-maintenance/2.15.x branch March 26, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants