Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update shutter widget color when closed #399

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Feb 10, 2025

In this PR the gray color (instead of magenta) is used to indicate when the shutter is closed, making it easier to distinguish its state.

Screenshot 2025-02-11 at 9 50 21 AM

NOTE: to fix pre-commit I had to update the types of the MDAWidget execute_mda and run_mda methods.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (68f8dee) to head (d0d2d99).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files          85       85           
  Lines        9360     9362    +2     
=======================================
+ Hits         8485     8487    +2     
  Misses        875      875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant