Skip to content

Commit

Permalink
Use a less sloppy check in remove_avoided_requirements
Browse files Browse the repository at this point in the history
See pyodide/pyodide#5187. In that issue, the build
requires a package called `cmake-build-extension` but because we have `cmake` in
the list of requirements to avoid we drop it and it breaks the build.

This logic was introduced in pyodide/pyodide#2272 and
did not come up in the review. Surprisingly this is the first problem it has
caused. Let's see if this change breaks anything in Pyodide CI.
  • Loading branch information
hoodmane committed Nov 11, 2024
1 parent fac0109 commit a612e38
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pyodide_build/pypabuild.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def remove_avoided_requirements(
for reqstr in list(requires):
req = Requirement(reqstr)
for avoid_name in set(avoided_requirements):
if avoid_name in req.name.lower():
if avoid_name == req.name.lower():
requires.remove(reqstr)
return requires

Expand Down

0 comments on commit a612e38

Please sign in to comment.