-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alternative index url when installing build dependencies #68
Open
ryanking13
wants to merge
20
commits into
pyodide:main
Choose a base branch
from
ryanking13:switch-index-url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This PR is ready to be reviewed now. I'll open a PR in pyodide/pyodide to test this. |
ryanking13
changed the title
[DRAFT] Use alternative index url when installing build dependencies
Use alternative index url when installing build dependencies
Jan 8, 2025
I guess I owe you a review on this one too. |
Yeah, a review would be helpful, thanks! I think it is almost ready, but I am still trying to make pyodide/pyodide#5309 pass the test :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #43
This PR changes the index url for installing build dependency. The concept of this PR is explained in #43.
pyodide-build
will try to install the build dependencies fromhttps://pypi.anaconda.org/pyodide-build/
.If downloading the package is not available, it will fallback to PyPI.
When building recipes, recipes with
cross-build-env
/cross-build-files
will keep install the native packages to hostsitepackagesAdvantages
Pyodide xbuildenv no longer need to build the numpy and scipy or hold it in the zip file. Also upgrading the numpy and scipy will be decoupled from Pyodide release.
Drawbacks
After this PR, we need to manage a separate repository
pyodide-build-deps
. This repository contains a few recipes (numpy, scipy) and we need to update them when there are breaking changes in numpy or scipy.We also need to manage other common build dependencies. These packages can be simply mirrored from PyPI, so no complex setup is needed. But it can be annoying.