-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTR] model_creator #357
[RTR] model_creator #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Please add the relevent tests to the test suite :) and if possible that would be nice to update the example as well to showcase these new features!
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EveCharbie)
binding/python3/model_creation/inertia_parameters_real.py
line 84 at r1 (raw file):
com = np.nanmean(self.center_of_mass, axis=1)[:3] out_string = f"\tmass\t{self.mass}\n"
Any reason for prefering the tabs to the spaces?
binding/python3/model_creation/biomechanical_model.py
line 84 at r1 (raw file):
return model def add_real_muscles(self, model: BiomechanicalModelReal, data: Data):
Is this method necessary? It seems that the muscles are the only one that we could directly add at the model level (since the getter and setter for the segments was removed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pariterre)
binding/python3/model_creation/biomechanical_model.py
line 84 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Is this method necessary? It seems that the muscles are the only one that we could directly add at the model level (since the getter and setter for the segments was removed)
Done.
binding/python3/model_creation/inertia_parameters_real.py
line 84 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Any reason for prefering the tabs to the spaces?
Not readable to me with spaces XD (but I can revert if you want)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EveCharbie)
examples/python3/modelCreation.py
line 251 at r2 (raw file):
os.remove(kinematic_model_file_path)
Not sure what these dots are, spaces?
test/models/full_model_creator_test.bioMod
line 3 at r2 (raw file):
version 4 // SEGMENT DEFINITION
Is this model intended to be added to the repo? I feel like it was generated from a test, but the wrong file was versioned!
I added the things I needed in the model creator:
This change is