Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nox? #646

Closed
henryiii opened this issue Apr 22, 2021 · 3 comments · Fixed by #661
Closed

Use Nox? #646

henryiii opened this issue Apr 22, 2021 · 3 comments · Fixed by #661

Comments

@henryiii
Copy link
Contributor

In bin, we have some code that likely could be run by nox, and at least one piece of code that could be replaced by Nox. This could simplify some of the scripts - mostly looking at the first half of update_dependencies.py. It could be then run either from a Nox docker container, using the Nox action, or locally if someone has installed all the required versions of Python, without having the current --no-docker duplication.

This could possibly be augmented over time to take support running all our development actions, so a new developer could easily run these in a controlled environment without having to set up anything, and get a matching environment to the CI. I wasn't that fond of tox - too rigid with too many options and assumptions , but nox is not bad, much cleaner and more natural with nicer output. pip uses nox and tox (slowly transitioning to nox-only, I think). packaging and packaging.python.org use nox. Pretty much all the other pypa projects use tox.

Common dev actions would mostly be still available as a script (though the nox runner would install the requirements for you), though some actions (esp. ones like update_dependencies) could only run in Nox (mostly ones that require multiple Python versions).

Thoughts?

PS: personally, I run pipx run nox which means I don't have to install nox.

@henryiii
Copy link
Contributor Author

henryiii commented Apr 22, 2021

@henryiii
Copy link
Contributor Author

@joerick
Copy link
Contributor

joerick commented Apr 23, 2021

nox looks like a great tool! I never used tox myself, it always had this 'heavy' feeling, probably because of the configuration files.

It could be then run either from a Nox docker container, using the Nox action, or locally if someone has installed all the required versions of Python, without having the current --no-docker duplication.

If this is possible, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants