chore: cleanup style in bin #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
changed the title
henryiii
force-pushed
the
henryiii/style/b1
branch
from
07d0ca4 to
cd32113
Compare
henryiii
force-pushed
the
henryiii/style/b1
branch
from
cd32113 to
f932a9c
Compare
|
Test failures notwithstanding, these style changes look good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes several adjustments with the primary (original, anyway) target being a much nicer final Black result (Black not run yet). This (I think) also improves the readability of the code. Using full Python 3.7+ for
/bin(except for run_tests.py - that would be something perfect to move to nox, see #646!).