Show install progress when using --progress-bar=raw
#12601
Conversation
yes i installed mypy locally to test this, so it should finally pass ci
|
Currently need to install packages individually to get around this, this PR would make wrapping pip alot more efficient. |
| @@ -0,0 +1 @@ | |||
| Output install progress when 'raw' progress_bar type is in use | |||
There was a problem hiding this comment.
| Output install progress when 'raw' progress_bar type is in use | |
| Output machine readable install progress when "raw" ``--progress-bar`` is enabled. |
| if bar_type == "raw": | ||
| return functools.partial[Iterator[Tuple[str, InstallRequirement]]]( | ||
| _raw_progress_bar, size=total, unit_size=1 | ||
| ) |
There was a problem hiding this comment.
I tried dropping the functools.partial type parameter here and in get_download_progress_renderer() and mypy was fine with it? Although, I'm not sure whether it affects inference or not.
|
@joeyballentine are you able to click the "Merge pull request" button? |
|
I am not |
|
@ichard26 It looks like this PR was approved but never merged. Are you able to merge it? |
|
I cannot, no. I don't have the commit bit on this project. |
|
Hi, As I understand this is meant to provide machine readable output, this should really have tests, otherwise there is no guarantee at all that the behaviour will be preserved over time. OTOH, I'm not sure if pip did ever provide any guarantee about stability of it's logging output, and if we should encourage such use cases which would make it harder and harder to improve the logging output. For instance, one simple thing that I've wanted to do, but refrained out of fear of breaking downstream tools, is send all logging output to stderr and keep human or machine readable output only on stdout. So maybe we should clarify our stance about this topic before going further down that road? |
I agree generally. Not something I'm interested in doing at the moment though. Removing this from the milestone. |
This PR is a follow-up to #11508 / #12586 which adds machine-readable install progress outputs.
Right now, unless pip is uninstalling a package to upgrade it, pip does not output any progress information for the actual install process. This means that any GUI wrapping pip cannot accurately display the current progress of the install. For example, if I wanted to be able to display "installing opencv-python", I would have no idea when opencv-python is actually installing. The best I would be able to do would be to display an indeterminate progress spinner and maybe guess where the install progress is at based on the uninstalling messages.
So, this PR solves that issue by outputting the current install progress when the
--progress-barsetting is set to "raw". I did try to add a regular progress bar to this as well, but due to the extra logging it does sometimes (like during uninstalls), a regular progress bar is not a good fit for this specific feature. Besides, this is only useful for those who want to display extra information that they cannot currently get from pip's output (which is why someone would be using the "raw" option anyway).Example screenshot:
