Improve file-details with certificate claims #17145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # warehouse/templates/includes/file-details.html
woodruffw
reviewed
Nov 22, 2024
woodruffw
reviewed
Nov 22, 2024
woodruffw
reviewed
Nov 22, 2024
di
reviewed
Nov 22, 2024
di
reviewed
Nov 22, 2024
DarkaMaul
commented
Nov 26, 2024
DarkaMaul
commented
Nov 26, 2024
DarkaMaul
commented
Nov 26, 2024
DarkaMaul
force-pushed
the
dm/expose-claims
branch
from
658915f to
86a421e
Compare
DarkaMaul
force-pushed
the
dm/expose-claims
branch
from
86a421e to
a583a74
Compare
DarkaMaul
commented
Dec 2, 2024
| case "GitLab": | ||
| reference = reference.removeprefix("refs/heads/") | ||
| return f"{base_url}/-/tree/{reference}" | ||
| case _: |
There was a problem hiding this comment.
FLAG: I'm unsure if we want to do this - or simply return an error?
DarkaMaul
force-pushed
the
dm/expose-claims
branch
from
19c7243 to
cb23952
Compare
|
Part of #17001 |
di
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose Certificate Claims in UI
This PR implements the UI display of Sigstore certificate claims, providing a more comprehensive view of package attestations.
Implementation Details
pypi-attestationpypi-attestationreturns adict[str, str]mapping OIDs (dotted strings) to their decoded valuesDependencies
claimstoAttestationtrailofbits/pypi-attestations#70Currently using a temporary container update forpypi-attestation(to be removed before merge)Closes #17122
/cc @di @woodruffw @facutuesca