Make Delta.log_prob
jit-able on metal and raise explicit error for Delta
sampling site during initialization.
#1950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two
Delta
distribution related changes.jnp.log(value == self.v)
, whereself.v
is the value of theDelta
distribution. This is not jit-able on metal (cf.lambda x: jnp.log(x == 1)
is not jit-able on metal. jax-ml/jax#25935). The updated implementation usesjnp.where(value == self.v, 0, -jnp.inf)
which is equivalent but jit-able.Delta
sampling sites lead to a non-specific error messageRuntimeError: Cannot find valid initial parameters. Please check your model again.
. This change adds a line to check for unobservedDelta
sites in a model and raises a more explicit error.