Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip install calls compatible with zsh #1962

Merged
merged 1 commit into from
Jan 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
python -m pip install --upgrade pip
pip install jaxlib
pip install jax
pip install .[doc,test]
pip install '.[doc,test]'
pip install https://github.com/pyro-ppl/funsor/archive/master.zip
pip install -r docs/requirements.txt
pip freeze
Expand Down Expand Up @@ -70,7 +70,7 @@ jobs:
pip install jaxlib
pip install jax
pip install https://github.com/pyro-ppl/funsor/archive/master.zip
pip install -e .[dev,test]
pip install -e '.[dev,test]'
pip freeze
- name: Test with pytest
run: |
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
pip install jaxlib
pip install jax
pip install https://github.com/pyro-ppl/funsor/archive/master.zip
pip install -e .[dev,test]
pip install -e '.[dev,test]'
pip freeze
- name: Test with pytest
run: |
Expand Down Expand Up @@ -160,7 +160,7 @@ jobs:
pip install jaxlib
pip install jax
pip install https://github.com/pyro-ppl/funsor/archive/master.zip
pip install -e .[dev,examples,test]
pip install -e '.[dev,examples,test]'
pip freeze
- name: Test with pytest
run: |
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ To set up local development environment, install NumPyro from source:
```sh
git clone https://github.com/pyro-ppl/numpyro.git
# install jax/jaxlib first for CUDA support
pip install -e .[dev,test,doc,examples] # contains additional dependencies for NumPyro development
pip install -e '.[dev,test,doc,examples]' # contains additional dependencies for NumPyro development
```

For running `make doctest`, [install pandoc](https://pandoc.org/installing.html).
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ format: license FORCE
ruff format .

install: FORCE
pip install -e .[dev,doc,test,examples]
pip install -e '.[dev,doc,test,examples]'

doctest: FORCE
JAX_PLATFORM_NAME=cpu $(MAKE) -C docs doctest
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,13 @@ In case of compatibility issues arise during execution of the above command, you
compatible CPU version of JAX with

```
pip install numpyro[cpu]
pip install 'numpyro[cpu]'
```

To use **NumPyro on the GPU**, you need to install CUDA first and then use the following pip command:

```
pip install numpyro[cuda] -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
pip install 'numpyro[cuda]' -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
```

If you need further guidance, please have a look at the [JAX GPU installation instructions](https://github.com/jax-ml/jax#pip-installation-gpu-cuda).
Expand All @@ -265,7 +265,7 @@ You can also install NumPyro from source:
git clone https://github.com/pyro-ppl/numpyro.git
cd numpyro
# install jax/jaxlib first for CUDA support
pip install -e .[dev] # contains additional dependencies for NumPyro development
pip install -e '.[dev]' # contains additional dependencies for NumPyro development
```

You can also install NumPyro with conda:
Expand Down
4 changes: 2 additions & 2 deletions docker/dev/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ RUN apt update && \
ENV PATH=/root/.local/bin:$PATH

# install python packages via pip
RUN pip3 install jax[cuda] -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
RUN pip3 install 'jax[cuda]' -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html

# clone the numpyro git repository and run pip install
RUN git clone https://github.com/pyro-ppl/numpyro.git && \
cd numpyro && \
pip3 install -e .[dev, test] # contains additional dependencies for NumPyro development
pip3 install -e '.[dev, test]' # contains additional dependencies for NumPyro development
2 changes: 1 addition & 1 deletion docker/release/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ ENV PATH=/root/.local/bin:$PATH
RUN pip3 install --user \
# we pull wheels from google's api as per https://github.com/jax-ml/jax#installation
# the pre-compiled wheels that google provides work for now. This may change in the future (and necessitate building from source)
numpyro[cuda] -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
'numpyro[cuda]' -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
],
"cpu": f"jax[cpu]{_jax_version_constraints}",
# TPU and CUDA installations, currently require to add package repository URL, i.e.,
# pip install numpyro[cuda] -f https://storage.googleapis.com/jax-releases/jax_releases.html
# pip install 'numpyro[cuda]' -f https://storage.googleapis.com/jax-releases/jax_releases.html
"tpu": f"jax[tpu]{_jax_version_constraints}",
"cuda": f"jax[cuda]{_jax_version_constraints}",
},
Expand Down
Loading