-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
./cg/*.py
– format, lint, & remove docstring spaces
#608
Conversation
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
=====================================
Coverage 84.2% 84.2%
=====================================
Files 137 137
Lines 14780 14711 -69
=====================================
- Hits 12444 12389 -55
+ Misses 2336 2322 -14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe shorter diffs would be better for reviews.
How about smaller diffs for future PRs and keep this as is? Is that a fair comprise? |
Yeah for sure, I already went through all of this :D |
@martinfleis I think we should close this PR until I figure out what's going on with |
Oh, you are already done? Curious about those strange changes though. |
somehow the test are fine with that :D. Can you revert and check which errors it shows? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Seeing all this, we should probably try to move ahead with actual deprecation of most of the cg
sooner than later.
xref ##484 |
xref #589
This PR formats, lints, & removes docstring spaces from
./cg/*.py
. Even though I am trying to do this in coherent sections (left out allcg
subdirs) some of the PRs are going to be pains to review. I can split into file level PRs if desired.