Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./cg/*.py – format, lint, & remove docstring spaces #608

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

jGaboardi
Copy link
Member

xref #589

This PR formats, lints, & removes docstring spaces from ./cg/*.py. Even though I am trying to do this in coherent sections (left out all cg subdirs) some of the PRs are going to be pains to review. I can split into file level PRs if desired.

@jGaboardi jGaboardi requested a review from martinfleis October 26, 2023 13:13
@jGaboardi jGaboardi self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #608 (fef4ad3) into main (92bc9d1) will increase coverage by 0.0%.
The diff coverage is 87.7%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #608   +/-   ##
=====================================
  Coverage   84.2%   84.2%           
=====================================
  Files        137     137           
  Lines      14780   14711   -69     
=====================================
- Hits       12444   12389   -55     
+ Misses      2336    2322   -14     
Files Coverage Δ
libpysal/cg/kdtree.py 67.9% <100.0%> (ø)
libpysal/cg/polygonQuadTreeStructure.py 85.7% <100.0%> (-0.2%) ⬇️
libpysal/cg/shapely_ext.py 20.2% <100.0%> (+0.6%) ⬆️
libpysal/cg/standalone.py 91.3% <100.0%> (-0.2%) ⬇️
libpysal/cg/voronoi.py 88.6% <100.0%> (+0.9%) ⬆️
libpysal/cg/locators.py 60.1% <80.0%> (-0.7%) ⬇️
libpysal/cg/shapes.py 89.9% <95.7%> (+0.1%) ⬆️
libpysal/cg/rtree.py 90.9% <93.3%> (-0.1%) ⬇️
libpysal/cg/alpha_shapes.py 85.7% <85.0%> (+1.3%) ⬆️
libpysal/cg/sphere.py 72.9% <66.7%> (+0.3%) ⬆️
... and 1 more

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, maybe shorter diffs would be better for reviews.

@jGaboardi
Copy link
Member Author

Yeah, maybe shorter diffs would be better for reviews.

How about smaller diffs for future PRs and keep this as is? Is that a fair comprise?

@martinfleis
Copy link
Member

Yeah for sure, I already went through all of this :D

@jGaboardi
Copy link
Member Author

@martinfleis I think we should close this PR until I figure out what's going on with ruff. There are some very strange changes in here now that I see it.

@jGaboardi
Copy link
Member Author

Yeah for sure, I already went through all of this :D

Oh, you are already done? Curious about those strange changes though.

@martinfleis
Copy link
Member

Curious about those strange changes though.

somehow the test are fine with that :D. Can you revert and check which errors it shows?

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Seeing all this, we should probably try to move ahead with actual deprecation of most of the cg sooner than later.

@jGaboardi
Copy link
Member Author

Alright. Seeing all this, we should probably try to move ahead with actual deprecation of most of the cg sooner than later.

xref ##484

@jGaboardi jGaboardi merged commit 9684010 into pysal:main Oct 26, 2023
@jGaboardi jGaboardi deleted the lint_cg branch October 26, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants