Fixed invalid regex handling in filterwarnings #13124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Compiler
requested changes
Jan 11, 2025
…com/virendrapatil24/pytest into fix-invalid-regex-in-filterwarnings
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
graingert
reviewed
Jan 21, 2025
| ignore::DeprecationWarning:* | ||
| """ | ||
| ) | ||
| result = pytester.runpytest_subprocess() |
There was a problem hiding this comment.
we should assert on the exit code also
graingert
reviewed
Jan 21, 2025
| [pytest] | ||
| filterwarnings = | ||
| ignore::DeprecationWarning:* | ||
| """ |
graingert
reviewed
Jan 21, 2025
| result = pytester.runpytest_subprocess() | ||
| result.stderr.fnmatch_lines( | ||
| [ | ||
| "*Invalid regex '*': nothing to repeat at position 0*", |
There was a problem hiding this comment.
I think it would be more thorough to test on the whole "while parsing ..." output?
|
it looks like there's no tests for "invalid lineno (negative AND not an integer)", too many fields, invalid action or resolving the warning category perhaps you'd be interested in adding these tests? Should be very similar to test_invalid_regex_in_filterwarning perhaps in this PR or perhaps in a followup? |
graingert
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13119
parse_warning_filtermethod to handle invalid regex pattern provided to message/module args.