Show close reasons in close message #3240
Merged
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 There's two typos in the commit titles ("cahnnel", "ative"), other than that it looks good to me. |
ChrisLovering
force-pushed
the
Show-close-reasons
branch
from
e2a35b5 to
3fbd94a
Compare
vivekashok1221
requested changes
Jan 18, 2025
bot/exts/help_channels/_channel.py
Outdated
Comment on lines
54
to
58
| close_title += f" by OP with {constants.Bot.prefix}close" | ||
| elif closing_reason == _stats.ClosingReason.INACTIVE: | ||
| close_title += " for inactivity" | ||
| elif closing_reason == _stats.ClosingReason.NATIVE: | ||
| close_title += " by OP" |
There was a problem hiding this comment.
Moderators can close help channels too.
Do you think it's worth distinguishing between an OP closing the post and a moderator closing the post?
(lines 54 and 58)
There was a problem hiding this comment.
See most recent commits
mbaruh
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3173