change the full outpot view from link to button #3244
Conversation
| ctx.send.assert_called_once() | ||
| call_args = ctx.send.call_args | ||
| message_content = call_args.kwargs["content"] |
There was a problem hiding this comment.
> message_content = call_args.kwargs["content"]
E KeyError: 'content'
tests/bot/exts/utils/snekbox/test_snekbox.py:423: KeyError
CI is failing because content appears to be passed to ctx.send as a positional argument rather than a keyword argument. I believe this should fix it:
| message_content = call_args.kwargs["content"] | |
| message_content = call_args.args[0] |
| "has completed with return code 0." | ||
| "\n\n```ansi\nWay too long beard\n```\nFull output: lookatmybeard.com" | ||
| message_content, | ||
| ":white_check_mark: Your 3.12 eval job has completed with return code 0.\n\n```ansi\nToo long beard\n```", |
There was a problem hiding this comment.
The mock message and expected output are different.
| ":white_check_mark: Your 3.12 eval job has completed with return code 0.\n\n```ansi\nToo long beard\n```", | |
| ":white_check_mark: Your 3.12 eval job has completed with return code 0.\n\n```ansi\nWay too long beard\n```", |
| button = next( | ||
| (item for item in view.children if isinstance(item, ui.Button)), None | ||
| ) | ||
| self.assertIsNotNone(button) | ||
| self.assertEqual(button.label, "View Full Output") | ||
| self.assertEqual(button.url, "lookatmybeard.com") |
There was a problem hiding this comment.
Will button in this case be the "View Full Output" button or "Run in 13.3" button? (Run in 13.3 button appears first.)
There was a problem hiding this comment.
Check if the view contains the correct button
self.assertIsNotNone(view)
buttons = [item for item in view.children if isinstance(item, ui.Button)]
button = (
buttons[-1] if buttons else None
) # Get the last button if buttons exist`
what do you think about this ? @vivekashok1221 to check for the last button , which is always the View Full Output button
|
Hey @ChrisLovering , i cant commit because of that linting issue , that s why i changed it , how can i commit without fixing it ? |
Our pre-commit-config doesn't include a formatter that would make these changes. I suspect that you have black/ruff setup on your editor to format on save, which is causing these changes. You will need to disable that for this repository. |
AbdelbassitAb
force-pushed
the
full-output-button
branch
from
b9588e4 to
4bcbd50
Compare
No description provided.