Add draft config option to Create Pull Request #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Cool. Thanks @ambv ! |
|
Oh nice , thank you @ambv :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding draft parameter option to create pull request.
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#create-a-pull-request
At Airflow, we effectively use the cherry-picker tool to backport changes, which has been highly beneficial in saving maintainers' time.
Currently, we have configured cherry-picker in our workflows, utilizing the GITHUB_TOKEN to create backport PRs. However, our workflows are not triggered on these backported PRs. This limitation occurs because GitHub prevents recursive workflows when using the default token.
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#triggering-a-workflow-from-a-workflow .
To address this, we would like to create backport PRs in draft state. maintainer can then change them to the "Ready for Review" state, which will subsequently trigger the workflows.
Thank you @potiuk for the suggestion this.