Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128550: TaskGroup: cancel tasks added to set after aborting #128551

Closed
wants to merge 13 commits into from
Closed

gh-128550: TaskGroup: cancel tasks added to set after aborting #128551

wants to merge 13 commits into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Jan 6, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 6, 2025
Closed
@graingert graingert force-pushed the fix-taskgroup-eager branch from 41929bd to 9726c3d Compare January 6, 2025 16:04
@graingert
Copy link
Contributor Author

I'm refactoring the tests to run the TaskGroup tests on eager and lazy tasks and have found another issue. I'm afk at the moment and will fix that one shortly too

@graingert
Copy link
Contributor Author

Ok I have the other issue here: #128553

@graingert graingert marked this pull request as ready for review January 6, 2025 18:58
@graingert graingert closed this Jan 20, 2025
@graingert graingert deleted the fix-taskgroup-eager branch January 20, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
awaiting core review topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graingert @ZeroIntensity @AlexWaygood