GH-127178: improve compatibility in _sysconfig_vars_(...).json
#128558
+58
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves environment and platform compatibility - Data now matches `sysconfig.get_config_vars` after install - `userbase` now correctly reflects the target platform when cross-compiling - `test_sysconfigdata_json` now takes into account the following situations: - Running with a non-default sys.executable path - Running under virtual environments - Running under relocatable installs To simplify the detection of relocatable installs, which needs to look at `_sysconfigdata_(...)`, this module is now saved in `sys.modules`. As part of this change, the code to import the module from a specific directory was refactored to use `PathFinder`, simplifying the implementation. Signed-off-by: Filipe Laíns <[email protected]
FFY00
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
…rs() dependency Signed-off-by: Filipe Laíns <[email protected]
FFY00
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves environment and platform compatibility:
sysconfig.get_config_varsafter installuserbasenow correctly reflects the target platform when cross-compilingtest_sysconfigdata_jsonnow takes into account the following situations:sys.executablepathTo simplify the detection of relocatable installs, which needs to look at
_sysconfigdata_(...), this module is now saved insys.modules. As part of this change, the code to import the module from a specific directory was refactored to usePathFinder, simplifying the implementation.Signed-off-by: Filipe Laíns <[email protected]
_sysconfigdatato a JSON file #127178