[3.12] gh-128552: fix refcycles in eager task creation (#128553) #128586

graingert · 2025-01-07T12:23:06Z

(cherry picked from commit 61b9811)

Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552

(cherry picked from commit 61b9811)

Lib/test/test_asyncio/test_taskgroups.py

graingert · 2025-01-07T12:29:03Z

Lib/test/test_asyncio/test_taskgroups.py

+            try:
+                async with asyncio.TaskGroup() as tg2:
+                    task_wr = weakref.ref(tg2.create_task(coro_fn()))
+            except* _Done as excs:


looks like this needs the uncancel after leaving task group fix from 3.13 that wasn't backported

pythongh-128552: fix refcycles in eager task creation (python#128553)

5f624a0

(cherry picked from commit 61b9811)

bedevere-app bot mentioned this pull request Jan 7, 2025

TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552

Open

bedevere-app bot added the topic-asyncio label Jan 7, 2025

bedevere-app bot mentioned this pull request Jan 7, 2025

gh-128552: fix refcycles in eager task creation #128553

Merged

graingert commented Jan 7, 2025

View reviewed changes

Lib/test/test_asyncio/test_taskgroups.py Outdated Show resolved Hide resolved

graingert added 2 commits January 7, 2025 12:24

Update Lib/test/test_asyncio/test_taskgroups.py

9df724e

remove tests only valid in 3.13

e92aed1

graingert commented Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.12] gh-128552: fix refcycles in eager task creation (#128553) #128586

[3.12] gh-128552: fix refcycles in eager task creation (#128553) #128586

graingert commented Jan 7, 2025 •

edited by bedevere-app bot

Loading

graingert Jan 7, 2025 •

edited

Loading

[3.12] gh-128552: fix refcycles in eager task creation (#128553) #128586

Are you sure you want to change the base?

[3.12] gh-128552: fix refcycles in eager task creation (#128553) #128586

Conversation

graingert commented Jan 7, 2025 • edited by bedevere-app bot Loading

graingert Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

graingert commented Jan 7, 2025 •

edited by bedevere-app bot

Loading

graingert Jan 7, 2025 •

edited

Loading